Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Update CI runs to test twice: with and without the USE_GAMESTATE_API feature flags #963

Closed
itsalaidbacklife opened this issue Jun 16, 2024 · 0 comments · Fixed by #992
Labels
enhancement New feature or request testing automation

Comments

@itsalaidbacklife
Copy link
Contributor

itsalaidbacklife commented Jun 16, 2024

Feature Summary

Once we have completed the feature set for the GameState API, we should update CI so that we test the application twice: one build and test config that uses the GameState API, and one that uses the Legacy API.

Detailed Description

This way we can determine if we have successfully completed all the features such that the app is fully usable in both modes, before we clean up and switch over to the GameState API in production.

One cypress run should build the frontend with VITE_USE_GAMESTATE_API=true, then boot the backend with SAILS_USE_GAMESTATE_API=true and run the tests with CYPRESS_USE_GAMESTATE_API=true.

The other should build, boot, and run the tests without these environment variables set i.e. using the regular commands.

Production config should not be affected and should still OMIT these env vars in order to continue to use the Legacy API

In order to keep CI green, this update should fix all the tests that are broken in both boot modes before it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing automation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant