Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevEx]: Cleanup isFrozen prop clientside #988

Open
Haviles04 opened this issue Jul 30, 2024 · 0 comments · May be fixed by #1071
Open

[DevEx]: Cleanup isFrozen prop clientside #988

Haviles04 opened this issue Jul 30, 2024 · 0 comments · May be fixed by #1071
Labels
dev experience Improvements to the code base that make it easier/better/more enjoyable to contribute to Cuttle frontend Requires changes to the frontend (vue) client good first issue Good for newcomers version-patch An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1)

Comments

@Haviles04
Copy link
Contributor

Haviles04 commented Jul 30, 2024 •
edited
Loading

Improvement Summary

Cleanup isFrozen prop

Detailed Description

This should be released after or with #965

After PR #981 the GameCard component accepts a prop of is-frozen which is equal to "gameStore.player.frozenId === card.id || card.isFrozen" after successful deployment of the GameState API refactor we know longer need the first check of frozenId === card.id. The isFrozen attribute should be removed from the user model as well.
@Haviles04 Haviles04 added the dev experience Improvements to the code base that make it easier/better/more enjoyable to contribute to Cuttle label Jul 30, 2024
@Haviles04 Haviles04 added good first issue Good for newcomers version-patch An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1) frontend Requires changes to the frontend (vue) client labels Jul 30, 2024
nathanbpaul7 added a commit to nathanbpaul7/cuttle that referenced this issue Aug 22, 2024
@nathanbpaul7
cuttle-cards#988 deleted gameStore.player.frozenId boolean and frozen…
95cdf96 
…Id attribute from user model
nathanbpaul7 added a commit to nathanbpaul7/cuttle that referenced this issue Aug 22, 2024
@nathanbpaul7
cuttle-cards#988 fix: deleted unnecessary frozenId boolean check and …
1140b26 
…corresponding attribute in user model
@Mang0codes Mang0codes linked a pull request Oct 3, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev experience Improvements to the code base that make it easier/better/more enjoyable to contribute to Cuttle frontend Requires changes to the frontend (vue) client good first issue Good for newcomers version-patch An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1)
Projects
Move + GameState History MVP
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup isFrozen Mang0codes/cuttle
1 participant
@Haviles04