match d43, d65, etc.

[malcolmsailor]

I went ahead and implemented a regex to make other inversions prefaced by "d" also dominant seventh chords as I suggested in #1358. It was just a couple lines of code and it will allow me to clean up some of the stray chords still not matching with the tsvConverter.

NB pylint objects music21/roman.py:2378: [R0201(no-self-use), RomanNumeral._findSemitoneSizeForQuality] Method could be a function but this is not code introduced by me.

My remaining question is: perhaps 'd' should indicate dominant seventh quality no matter what digits follow? I.e., if a user indicates something weird like "d479', we should just pass the digits straight through but set impliedQuality to 'dominant-seventh'?

[coveralls]

Coverage decreased (-0.0009%) to 93.076% when pulling 41f264a on malcolmsailor:dominant_7ths into c2f5c6d on cuthbertLab:master.

[mscuthbert]

NB pylint objects music21/roman.py:2378: [R0201(no-self-use), RomanNumeral._findSemitoneSizeForQuality] Method could be a function but this is not code introduced by me.

We have no-self-use disabled in the music21 pylint configuration. Make sure that pylint is reading the file.

[mscuthbert]

Great! Some small and fast changes then ready to go. Thanks!

[malcolmsailor]

We have no-self-use disabled in the music21 pylint configuration. Make sure that pylint is reading the file.

I don't see it in the .pylintrc in the repository root directory. Is there more pylint configuration elsewhere?

[mscuthbert]

We have no-self-use disabled in the music21 pylint configuration. Make sure that pylint is reading the file.

I don't see it in the .pylintrc in the repository root directory. Is there more pylint configuration elsewhere?

Ah! For various reasons, we have to put the configuration in twice -- once in music21/test/testLint.py and once in the .pylintrc -- they're supposed to be kept perfectly in sync, but obviously they weren't for this point.

[mscuthbert]

Looking good. Letting tests run (I should've had you do a one-byte PR to get you approved as not "first-time-contributor" long ago), and if all pass will merge. THANKS!

[malcolmsailor]

Looking good. Letting tests run (I should've had you do a one-byte PR to get you approved as not "first-time-contributor" long ago), and if all pass will merge. THANKS!

As you can see the tests are failing with the same error I referenced in #1267; any suggestions for what might be going on with that are welcome.

[mscuthbert]

It's the 3.10.6 change that was causing the failure. Fix pushed and running tests again.

[mscuthbert]

We have no-self-use disabled in the music21 pylint configuration. Make sure that pylint is reading the file.

I don't see it in the .pylintrc in the repository root directory. Is there more pylint configuration elsewhere?

Ah -- no-self-use was moved to an optional extension in recent versions of pylint, and is no longer checked. So the solution is to upgrade your pylint.

[mscuthbert]

Merged. Congrats!