added search customer by email api #124
Merged
+101
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-engel
requested changes
Nov 22, 2022
lib/api.ts
Outdated
| @@ -51,6 +52,14 @@ export class APIClient { | |||
| return this.request.post(`${this.apiRoot}/send/email`, req.message); | |||
| } | |||
|
|
|||
| getCustomersByEmail(email: string) { | |||
| if (typeof email !== 'string' || !email) { | |||
There was a problem hiding this comment.
We prefer the isEmpty util to the ! operator to catch cases where the value is an empty string
| t.truthy((t.context.client.request.get as SinonStub).calledWith(`${RegionUS.apiUrl}/customers?email=${email}`)); | ||
| }) | ||
|
|
||
| test('#getCustomersByEmail: should throw error when email is empty', (t) => { |
There was a problem hiding this comment.
Another test should be added for cases where null/undefined or a non-string object are used for non-typescript clients
|
@mike-engel could you take another look? |
mike-engel
reviewed
Nov 30, 2022
There was a problem hiding this comment.
Thanks @PFadel! One last thing I forgot—can you add documentation to the readme?
@mike-engel done! |
|
@mike-engel could you take another look? <3 |
mike-engel
approved these changes
Dec 6, 2022
|
Thanks for your patience @PFadel. This was included with 3.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the example:
getCustomersByEmail.js
Features:
Added get method
Url encode emails
updates from: #89