❓ journal title can be optionally added

curvenote · Sep 12, 2024 · da3b548 · da3b548
1 parent c064f2a
commit da3b548
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 13 deletions.
diff --git a/packages/web/src/pmcFromManifest.ts b/packages/web/src/pmcFromManifest.ts
@@ -33,12 +33,18 @@ function treeFromManifest(manifest: AAMDepositManifest) {
     validatePMCFunder(funding.funder);
   });
 
-  const children = [
-    e('journal-meta', [
-      e('issn', { 'issn-type': manifest.metadata.journal.issnType }, [
-        t(manifest.metadata.journal.issn),
-      ]),
+  const journalMeta = e('journal-meta', [
+    e('issn', { 'issn-type': manifest.metadata.journal.issnType }, [
+      t(manifest.metadata.journal.issn),
     ]),
+  ]);
+
+  if (manifest.metadata.journal.title) {
+    journalMeta.children.push(e('journal-title', [t(manifest.metadata.journal.title)]));
+  }
+
+  const children = [
+    journalMeta,
     e('manuscript-title', [t(manifest.metadata.title)]),
     e('contacts', [
       e('person', {

diff --git a/packages/web/src/schema/manifest.ts b/packages/web/src/schema/manifest.ts
@@ -14,8 +14,8 @@ const fileSchema = z.object({
 const journalSchema = z.object({
   issn: z.string().min(1),
   issnType: z.enum(['print', 'electronic']),
-  title: z.string().min(1),
-  shortTitle: z.string().min(1),
+  title: z.string().optional(),
+  shortTitle: z.string().optional(),
 });
 
 // Schema for the 'authors' array

diff --git a/site/app/components/manifest.json b/site/app/components/manifest.json
@@ -1,5 +1,4 @@
 {
-  "taskId": "task-1234",
   "agency": "hhmi",
   "files": [
     {
@@ -39,10 +38,8 @@
   "metadata": {
     "title": "My Research Article",
     "journal": {
-      "issn": "1234-567",
-      "issnType": "electronic",
-      "title": "Journal",
-      "shortTitle": "J."
+      "issn": "0094-6354",
+      "issnType": "print"
     },
     "authors": [
       {
@@ -52,6 +49,6 @@
         "contactType": "reviewer"
       }
     ],
-    "funding": [{ "funder": "hhmi" }, { "funder": "nih", "grantId": "q1w2e3r4" }]
+    "funding": [{ "funder": "hhmi" }, { "funder": "nih", "grantId": "5R33MH125126-04" }]
   }
 }