Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment and Selection Plugins #99

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Comment and Selection Plugins #99

wants to merge 19 commits into from

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Nov 19, 2021 •
edited
Loading

  • Revisit demo, see if we can simplify.
  • Review selection / comment.

@rowanc1 rowanc1 force-pushed the feat/selection-plugin branch 5 times, most recently from f5ef8a5 to b0022a7 Compare November 23, 2021 22:32
rowanc1
rowanc1 commented Dec 21, 2021
View reviewed changes
Copy link
Member Author

@rowanc1 rowanc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking a look through.

src/prosemirror/plugins/comments.ts
Comment on lines +121 to +125
// TODO: This has to be based on the actual from/to
// NodeSelection.create(tr.doc, from);
// if (isNodeSelection(tr.selection)) {
// deco = Decoration.node(from, to, params, spec);
// }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rowanc1 @Yxwww