Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#34] Execute block number and timestamp #46

Merged
merged 16 commits into from
Jan 6, 2021

Conversation

daenamkim
Copy link
Collaborator

@daenamkim daenamkim commented Dec 7, 2020

Resolves #34

Add new custom formulas (functions) to deal with a block number and a timestamp.

@daenamkim
Copy link
Collaborator Author

This will be done after https://github.com/curvegrid/multibaas/pull/2899 is complete

@shoenseiwaso shoenseiwaso self-assigned this Dec 13, 2020
@daenamkim daenamkim marked this pull request as ready for review December 18, 2020 12:31
@daenamkim
Copy link
Collaborator Author

daenamkim commented Dec 18, 2020

@shoenseiwaso FYI, I tried a lot, currently Apps Script could not be updated from Google Workspace Marketplace SDK (or something wrong Google Sheets?) but I have no idea because there is no error. For this reason I tested manually this using integrated scripts in a spreadsheet.

No system issue as well:

And CI test codes will be done through #54 after MultiBaas is deployed.

Copy link
Collaborator

@shoenseiwaso shoenseiwaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Will wait to review further until the MultiBaas changes are rolled out.

Copy link
Collaborator

@shoenseiwaso shoenseiwaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

image

@daenamkim daenamkim merged commit 7bf3955 into master Jan 6, 2021
@shoenseiwaso shoenseiwaso deleted the 34-execute-block-number-and-timestamp branch January 9, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add functions to execute at a block number or at a timestamp
2 participants