Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[noissue] v0.3.8 #493

Merged
merged 8 commits into from
Oct 30, 2024
Merged

[noissue] v0.3.8 #493

merged 8 commits into from
Oct 30, 2024

Conversation

n0thingness
Copy link
Contributor

@n0thingness n0thingness commented Oct 30, 2024 •
edited
Loading

  • Bump version to prep for release with updated dependancies
  • migration to eslint v9
  • still get abi from hardhat artifact, but get bytecode from ethers contract factory so that library code is embedded directly in uploaded bytecode, so as to avoid JSON parsing error due to __$ $__ library code placeholders in solc output
  • added npm run deploy:all to sample project as a quick, fool proof way to check that everything still compiles, uploads, and deploys

shoenseiwaso
shoenseiwaso approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@shoenseiwaso shoenseiwaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@n0thingness n0thingness merged commit 7c4e586 into main Oct 30, 2024
@n0thingness n0thingness deleted the noissue-0.3.8 branch October 30, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoenseiwaso shoenseiwaso shoenseiwaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n0thingness @shoenseiwaso