Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardhat-deploy plugin #433

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

hardhat-deploy plugin #433

wants to merge 5 commits into from

Conversation

nataouze
Copy link
Collaborator

No description provided.

@nataouze nataouze marked this pull request as ready for review October 2, 2024 01:43
src/index.ts Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@n0thingness
Copy link
Contributor

n0thingness commented Dec 9, 2024

Just to summarize our sync:

  • Goal for this PR is to make it possible to use our plugin as part of a hardhat-deploy workflow
  • To do so, it was necessary to rearrange the order of steps in the plugin's deploy.ts to separate the actions that much be done on the MultiBaas deployment from the steps that deploy the contract to the blockchain
  • For now, we should unify the sample projects, so that we have examples of using both deploy pathways in a single project, and document in the readme that deploys can be performed in either style
  • As a follow up, we should investigate if want to make hardhat-deploy the main way of deploying contracts. Basically we would move the blockchain deployment steps out of the plugin, and just handle "submitting" the deployment results to MultiBaas. This would also better align the plugin with how things are done on forge-multibaas
  • We should think about if there is a better verb we can use than "submit"

import { CompilerSettings, OutputSelection } from "./types";
import * as types from "hardhat/internal/core/params/argumentTypes";

export const MULTIBAAS_SUBMIT_TASKNAME = "mb-submit";
Copy link
Contributor

@n0thingness n0thingness Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const MULTIBAAS_SUBMIT_TASKNAME = "mb-submit";
export const MULTIBAAS_LINK_TASKNAME = "mb-link";

following a discussion with @shoenseiwaso

);
}

async function submitDeployment(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just call this link(

*
* @returns an array consisting of [Contract (`ethers.js`'s `Contract`), MultiBaasContract, MultiBaasAddress] in order
*/
async submitDeployment(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This as well, we can just call it link(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants