-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hardhat-deploy plugin #433
base: main
Are you sure you want to change the base?
Conversation
…de, remove deployment files from plugin folder
Co-authored-by: Daniel Briskin <[email protected]>
Just to summarize our sync:
|
import { CompilerSettings, OutputSelection } from "./types"; | ||
import * as types from "hardhat/internal/core/params/argumentTypes"; | ||
|
||
export const MULTIBAAS_SUBMIT_TASKNAME = "mb-submit"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export const MULTIBAAS_SUBMIT_TASKNAME = "mb-submit"; | |
export const MULTIBAAS_LINK_TASKNAME = "mb-link"; |
following a discussion with @shoenseiwaso
); | ||
} | ||
|
||
async function submitDeployment( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just call this link(
* | ||
* @returns an array consisting of [Contract (`ethers.js`'s `Contract`), MultiBaasContract, MultiBaasAddress] in order | ||
*/ | ||
async submitDeployment( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This as well, we can just call it link(
No description provided.