-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#214] improve sample project #279
Conversation
Conflicts: sample/hardhat.config.ts
…ess to its own script
…pile can run without an mb config
…ng the hardhat multibaas plugin
Note: before 59bfcc9 , the contract tests in the sample project used Hardhat Tasks to deploy the contracts to MultiBaas and run the tests on those deployed instances This legacy approach was atypical, so we removed it in favour of standard-style Hardhat tests. However, it is worth noting that the legacy approach to testing served as an additional regression test for change made in the plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Resolves #214