feat: twap-like function for balance #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertoCentonze
requested changes
Sep 16, 2024
There was a problem hiding this comment.
Nice job!
We need to find a better name for this, since as we discussed, we're not talking about price. Maybe TWAB?
You're missing a mamushi format pass! Don't format there's a bug with 0.3.10 files.
Regarding the organisation of unit tests what I like to do is (will document this later):
- one folder per contract/module (i.e.
RewardsHandler.vygoes intotests/unitary/rewards_handler - in the folder, one file per function, both internal and externals (i.e.
tests/unitary/rewards_handler/test_<function_name>) - one test per branch (happy path is called
test_default_behavior)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
.pre-commit-config.yamlandpyproject.tomlto use a 120 character line width.contracts/TWAP.vyfor time-weighted rate tracking using trapezoidal interpolation.contracts/RewardsHandler.vyto integrate time-weighted rate calculations.tests/unitary/test_twap.pyto validate the TWAP functionality and correctness.