Bump @svgr/cli from 5.5.0 to 6.1.2, remove @svgr/rollup #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
michaeljaltamirano
suggested changes
Dec 14, 2021
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/svgr/rollup-6.1.2
branch
from
8af0fe2 to
fb15869
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/svgr/rollup-6.1.2
branch
from
fb15869 to
3777533
Compare
Bumps [@svgr/rollup](https://github.com/gregberge/svgr) from 5.5.0 to 6.1.2. - [Release notes](https://github.com/gregberge/svgr/releases) - [Changelog](https://github.com/gregberge/svgr/blob/main/CHANGELOG.md) - [Commits](gregberge/svgr@v5.5.0...v6.1.2) --- updated-dependencies: - dependency-name: "@svgr/rollup" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/svgr/rollup-6.1.2
branch
from
3777533 to
534c68a
Compare
This was referenced Dec 15, 2021
…reserve v5 output form (function vs. const)
michaeljaltamirano
changed the title
michaeljaltamirano
approved these changes
Dec 27, 2021
There was a problem hiding this comment.
When we originally added svgr we were also using @svgr/webpack and importing svg as React component directly. We no longer do that, so this PR removes @svgr/rollup in favor of the cli-only approach.
Other changes:
- Renames
src/svgs/glyphs/flag-u-k-glyph.svg → src/svgs/glyphs/flag-uk-glyph.svgandsrc/svgs/glyphs/flag-u-s-a-glyph.svg → src/svgs/glyphs/flag-usa-glyph.svgto reflect the casing of the icons as they exist in our component library - SVG component output includes
<title>now (part of the large snapshot diff).
| <path | ||
| fillRule="evenodd" | ||
| clipRule="evenodd" | ||
| d="M28.086 3l-2.267 2.809.972.785 2.268-2.809L28.086 3zm-8.643.789l.973-.785 2.266 2.81-.973.785-2.266-2.81zM12.786 19.04l3.552-2.204.659 1.062-3.552 2.204-.66-1.063zm17.47-1.14l.66-1.062 3.552 2.205-.66 1.062-3.551-2.205zm1.104 6.235a1.18 1.18 0 100-2.36 1.18 1.18 0 000 2.36zm-13.31-1.18a1.18 1.18 0 11-2.36 0 1.18 1.18 0 012.36 0zm6.2 6.8c-1.63 0-2.91-.9-2.91-2.04 0-1.14 1.28-2.04 2.91-2.04 1.63 0 2.91.9 2.91 2.04 0 1.14-1.28 2.04-2.91 2.04zm0-3.08c-1.13 0-1.91.55-1.91 1.04s.78 1.04 1.91 1.04 1.91-.55 1.91-1.04-.78-1.04-1.91-1.04zm14.5-2.68c0-8.132-6.62-14.753-14.75-14.753-8.13 0-14.75 6.621-14.75 14.753S15.87 38.75 24 38.75c8.13 0 14.75-6.622 14.75-14.754zm-30.75 0c0-8.842 7.16-16.004 16-16.004s16 7.172 16 16.004C40 32.838 32.84 40 24 40S8 32.838 8 23.996z" | ||
| d="m28.086 3-2.267 2.809.972.785 2.268-2.809L28.086 3Zm-8.643.789.973-.785 2.266 2.81-.973.785-2.266-2.81ZM12.786 19.04l3.552-2.204.659 1.062-3.552 2.204-.66-1.063Zm17.47-1.14.66-1.062 3.552 2.205-.66 1.062-3.551-2.205Zm1.104 6.235a1.18 1.18 0 1 0 0-2.36 1.18 1.18 0 0 0 0 2.36Zm-13.31-1.18a1.18 1.18 0 1 1-2.36 0 1.18 1.18 0 0 1 2.36 0Zm6.2 6.8c-1.63 0-2.91-.9-2.91-2.04 0-1.14 1.28-2.04 2.91-2.04 1.63 0 2.91.9 2.91 2.04 0 1.14-1.28 2.04-2.91 2.04Zm0-3.08c-1.13 0-1.91.55-1.91 1.04s.78 1.04 1.91 1.04 1.91-.55 1.91-1.04-.78-1.04-1.91-1.04Zm14.5-2.68c0-8.132-6.62-14.753-14.75-14.753-8.13 0-14.75 6.621-14.75 14.753S15.87 38.75 24 38.75c8.13 0 14.75-6.622 14.75-14.754Zm-30.75 0c0-8.842 7.16-16.004 16-16.004s16 7.172 16 16.004C40 32.838 32.84 40 24 40S8 32.838 8 23.996Z" |
There was a problem hiding this comment.
We are deferring to whatever svgr/svgo is outputting as best practice / optimized. For reference, the original svg is ~2kb:
<svg width="48" height="48" viewBox="0 0 48 48" fill="none" xmlns="http://www.w3.org/2000/svg">
<title>Anxious Emoji</title>
<path fill-rule="evenodd" clip-rule="evenodd" d="M28.086 3L25.8186 5.80894L26.7912 6.59407L29.0586 3.78513L28.086 3ZM19.4433 3.78889L20.4164 3.00439L22.6821 5.81478L21.7089 6.59928L19.4433 3.78889ZM12.7859 19.0405L16.3376 16.8368L16.9966 17.8989L13.4449 20.1026L12.7859 19.0405ZM30.2568 17.9012L30.9162 16.8392L34.4675 19.0442L33.8082 20.1062L30.2568 17.9012ZM31.3599 24.1359C32.0116 24.1359 32.5399 23.6076 32.5399 22.9559C32.5399 22.3042 32.0116 21.7759 31.3599 21.7759C30.7082 21.7759 30.1799 22.3042 30.1799 22.9559C30.1799 23.6076 30.7082 24.1359 31.3599 24.1359ZM18.0499 22.9559C18.0499 23.6076 17.5216 24.1359 16.8699 24.1359C16.2183 24.1359 15.6899 23.6076 15.6899 22.9559C15.6899 22.3042 16.2183 21.7759 16.8699 21.7759C17.5216 21.7759 18.0499 22.3042 18.0499 22.9559ZM24.25 29.7568C22.62 29.7568 21.34 28.8568 21.34 27.7168C21.34 26.5768 22.62 25.6768 24.25 25.6768C25.88 25.6768 27.16 26.5768 27.16 27.7168C27.16 28.8568 25.88 29.7568 24.25 29.7568ZM24.25 26.6768C23.12 26.6768 22.34 27.2268 22.34 27.7168C22.34 28.2068 23.12 28.7568 24.25 28.7568C25.38 28.7568 26.16 28.2068 26.16 27.7168C26.16 27.2268 25.38 26.6768 24.25 26.6768ZM38.75 23.9962C38.75 15.8643 32.13 9.24269 24 9.24269C15.87 9.24269 9.25 15.8643 9.25 23.9962C9.25 32.1281 15.87 38.7497 24 38.7497C32.13 38.7497 38.75 32.1281 38.75 23.9962ZM8 23.9962C8 15.1541 15.16 7.9924 24 7.9924C32.84 7.9924 40 15.1641 40 23.9962C40 32.8383 32.84 40 24 40C15.16 40 8 32.8383 8 23.9962Z" fill="currentColor"/>
</svg>The prev diff is 974kb:
<svg width="48" height="48" viewBox="0 0 48 48" fill="none" xmlns="http://www.w3.org/2000/svg">
<title>Anxious Emoji</title>
<path fill-rule="evenodd" clip-rule="evenodd" d="M28.086 3l-2.267 2.809.972.785 2.268-2.809L28.086 3zm-8.643.789l.973-.785 2.266 2.81-.973.785-2.266-2.81zM12.786 19.04l3.552-2.204.659 1.062-3.552 2.204-.66-1.063zm17.47-1.14l.66-1.062 3.552 2.205-.66 1.062-3.551-2.205zm1.104 6.235a1.18 1.18 0 100-2.36 1.18 1.18 0 000 2.36zm-13.31-1.18a1.18 1.18 0 11-2.36 0 1.18 1.18 0 012.36 0zm6.2 6.8c-1.63 0-2.91-.9-2.91-2.04 0-1.14 1.28-2.04 2.91-2.04 1.63 0 2.91.9 2.91 2.04 0 1.14-1.28 2.04-2.91 2.04zm0-3.08c-1.13 0-1.91.55-1.91 1.04s.78 1.04 1.91 1.04 1.91-.55 1.91-1.04-.78-1.04-1.91-1.04zm14.5-2.68c0-8.132-6.62-14.753-14.75-14.753-8.13 0-14.75 6.621-14.75 14.753S15.87 38.75 24 38.75c8.13 0 14.75-6.622 14.75-14.754zm-30.75 0c0-8.842 7.16-16.004 16-16.004s16 7.172 16 16.004C40 32.838 32.84 40 24 40S8 32.838 8 23.996z" fill="currentColor"/>
</svg>And the new one is 978kb:
<svg width="48" height="48" viewBox="0 0 48 48" fill="none" xmlns="http://www.w3.org/2000/svg">
<title>Anxious Emoji</title>
<path fill-rule="evenodd" clip-rule="evenodd" d="m28.086 3-2.267 2.809.972.785 2.268-2.809L28.086 3Zm-8.643.789.973-.785 2.266 2.81-.973.785-2.266-2.81ZM12.786 19.04l3.552-2.204.659 1.062-3.552 2.204-.66-1.063Zm17.47-1.14.66-1.062 3.552 2.205-.66 1.062-3.551-2.205Zm1.104 6.235a1.18 1.18 0 1 0 0-2.36 1.18 1.18 0 0 0 0 2.36Zm-13.31-1.18a1.18 1.18 0 1 1-2.36 0 1.18 1.18 0 0 1 2.36 0Zm6.2 6.8c-1.63 0-2.91-.9-2.91-2.04 0-1.14 1.28-2.04 2.91-2.04 1.63 0 2.91.9 2.91 2.04 0 1.14-1.28 2.04-2.91 2.04Zm0-3.08c-1.13 0-1.91.55-1.91 1.04s.78 1.04 1.91 1.04 1.91-.55 1.91-1.04-.78-1.04-1.91-1.04Zm14.5-2.68c0-8.132-6.62-14.753-14.75-14.753-8.13 0-14.75 6.621-14.75 14.753S15.87 38.75 24 38.75c8.13 0 14.75-6.622 14.75-14.754Zm-30.75 0c0-8.842 7.16-16.004 16-16.004s16 7.172 16 16.004C40 32.838 32.84 40 24 40S8 32.838 8 23.996Z" fill="currentColor"/>
</svg>There was a problem hiding this comment.
They're identical to the eye (Github won't let me attach them), and I imagine the same applies to the majority of this diff.
michaeljaltamirano
temporarily deployed
to
curology-rad-dependabot-r5rc7v
michaeljaltamirano
deleted the
dependabot/npm_and_yarn/svgr/rollup-6.1.2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps @svgr/rollup from 5.5.0 to 6.1.2.
Release notes
Sourced from
@svgr/rollup's releases.... (truncated)
Changelog
Sourced from
@svgr/rollup's changelog.Commits
3991389v6.1.245a76edfix: specify valid peer deps12627fcfix(rollup): missing dep & missing map return (#652)e89fbd1docs: correct the resourceQuery comment (#650)214564cv6.1.17595d37fix(webpack): fix double export (#648)d36254edocs: small text fix in mgrate.mdx (#646)81ef01cdocs: small text fix in custom-templates.mdx (#647)54676c3Merge pull request #642 from gregberge/upgrade-depsc62bc91docs: fix typo Jest -> MochaDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)