fix: add overflow behavior to integer division (substrait-io#223)

BREAKING CHANGE: The signature of divide functions for multiple types now specify an enumeration prior to specifying operands.
curino · Jul 20, 2022 · 7f5d120 · 7f5d120
1 parent c9469ee
commit 7f5d120
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/extensions/functions_arithmetic.yaml b/extensions/functions_arithmetic.yaml
@@ -126,18 +126,26 @@ scalar_functions:
     description: "Divide one value by another. Partial values are truncated."
     impls:
       - args:
+          - options: [ SILENT, SATURATE, ERROR ]
+            required: false
           - value: i8
           - value: i8
         return: i8
       - args:
+          - options: [ SILENT, SATURATE, ERROR ]
+            required: false
           - value: i16
           - value: i16
         return: i16
       - args:
+          - options: [ SILENT, SATURATE, ERROR ]
+            required: false
           - value: i32
           - value: i32
         return: i32
       - args:
+          - options: [ SILENT, SATURATE, ERROR ]
+            required: false
           - value: i64
           - value: i64
         return: i64