Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23 - Re-add dependencies lost during switch to poetry #26

Merged
merged 1 commit into from
May 25, 2022

Conversation

xkortex
Copy link
Contributor

@xkortex xkortex commented May 25, 2022

Fix for #23

Looks like during the switch to poetry, the dependencies six and sortedcontainers were lost as primary dependencies. They still existed in the lockfile as dev dependencies, which is why I think they may have fallen through the cracks.

Tested by doing poetry build in a blank env, pip installing the wheel, and ensuring all the imports work. Also ran CI with act, although CI that missed this bug the first time. Not sure what kind of regression test would catch that.

CI passed for all but python 3.10, not sure what's up with that, but it might just be an artifact of using act.

If this approved and CI passes, feel free to merge immediately for me, this is probably time sensitive.

@cunla cunla merged commit 19d3947 into cunla:master May 25, 2022
@xkortex xkortex deleted the xkortex/fix/23-dependencies branch May 25, 2022 19:48
@shadchin
Copy link

@cunla
Copy link
Owner

cunla commented May 26, 2022

I tested it - it works without it because packaging is a requirement of redis-py (and redis-py of fakeredis).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants