23 - Re-add dependencies lost during switch to poetry #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #23
Looks like during the switch to poetry, the dependencies
six
andsortedcontainers
were lost as primary dependencies. They still existed in the lockfile as dev dependencies, which is why I think they may have fallen through the cracks.Tested by doing
poetry build
in a blank env,pip install
ing the wheel, and ensuring all the imports work. Also ran CI withact
, although CI that missed this bug the first time. Not sure what kind of regression test would catch that.CI passed for all but python 3.10, not sure what's up with that, but it might just be an artifact of using
act
.If this approved and CI passes, feel free to merge immediately for me, this is probably time sensitive.