-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include tests in sdist #133
Conversation
Include the test suite in sdist archives, in order to make it possible for distribution packagers to use them rather than generated GitHub archives.
Why do you want the tests included? |
Gentoo packages provide support for running tests prior to installing the package in order to verify that it works. |
Can you provide some context on it? |
I don't understand what you're asking for. Gentoo Linux provides packages for various Python, well, packages. As part of package building process, users can opt in to run test suites against their system and Python versions. This way they can reduce the risk of hitting breakage at runtime, particularly if they're running a less common setup. |
Have you tried running the tests for this package? Can you provide me how to run tests in gentoo for this? |
Yes, we are running tests for quite a while. I admit there are a few known failures but most of them pass. We are starting a local redis server for the duration of the test suite. The code is here: https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-python/fakeredis/fakeredis-2.10.2.ebuild#n66 To run ebuild with tests enabled, normally you run:
However, this will also enable tests on all dependencies which can be time consuming. You can enable it per package by defining e.g.
and then using in
|
Got you, ok, I see the need. I am not sure how to write a test for it here so I'll merge. |
Thank you! |
Include the test suite in sdist archives, in order to make it possible for distribution packagers to use them rather than generated GitHub archives.