Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lmove operation #11

Merged
merged 4 commits into from
May 23, 2022
Merged

add lmove operation #11

merged 4 commits into from
May 23, 2022

Conversation

BGroever
Copy link
Contributor

@BGroever BGroever commented May 22, 2022

add lmove operation

@cunla
Copy link
Owner

cunla commented May 22, 2022

can you add tests to the command?

@BGroever
Copy link
Contributor Author

can you add tests to the command?

Yes, stil working on that. I just created the PR for better code review. I will ping you when I am done.

@cunla
Copy link
Owner

cunla commented May 23, 2022

@BGroever, can you check why the tests are failing with redis <= 4.0.1 and aioredis==1.3.1?
If you wish to reproduce locally, you can use poetry commands:

poetry install
poetry run pip install redis==4.0.1 aioredis==1.3.1
poetry run pytest -v

@cunla
Copy link
Owner

cunla commented May 23, 2022

Actually, just realized the tests fail because of changes in redis-py ver 4.1.2 - I will add a new annotation for tests that should run only for redis>4.1.2

@cunla cunla merged commit b189fa5 into cunla:master May 23, 2022
@renovate renovate bot mentioned this pull request Oct 15, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants