Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update copy back button #176

Merged
merged 1 commit into from
May 8, 2024
Merged

Update copy back button #176

merged 1 commit into from
May 8, 2024

Conversation

corneelwille
Copy link
Collaborator

@corneelwille corneelwille commented May 8, 2024 •
edited
Loading

Changed

  • Copy of the back button after release of publiq platform

Screenshot 2024-05-08 at 14 16 46

LucWollants
LucWollants approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@LucWollants LucWollants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved, but normally this should also be controlled with the toggle for publiq-platform.

@JonasVHG
Copy link

JonasVHG commented May 8, 2024

I approved, but normally this should also be controlled with the toggle for publiq-platform.

I think It got lost in a merge: https://github.com/cultuurnet/widget-beheer-angular/pull/167/files#diff-966e4667848a351f7a85b9d081ead9e9bdbfa602f2f966d3486d6b593240641b

@corneelwille corneelwille merged commit 2c23fc7 into master May 8, 2024
2 checks passed
@LucWollants LucWollants deleted the update-copy-back-button branch August 12, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasVHG JonasVHG JonasVHG approved these changes

@LucWollants LucWollants LucWollants approved these changes

@Anahkiasen Anahkiasen Awaiting requested review from Anahkiasen

@brampauwelyn brampauwelyn Awaiting requested review from brampauwelyn

@simon-debruijn simon-debruijn Awaiting requested review from simon-debruijn

@vhande vhande Awaiting requested review from vhande

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corneelwille @JonasVHG @LucWollants