feat: support for grouppasses #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: #UPS-5301
Refs: #UPS-5301
Refs: #UPS-5301
Refs: #UPS-5301
…ith theme colors Refs: #UPS-5301
d-vostrikov
force-pushed
the
feat/group-passes
branch
from
bfda09b to
c909de9
Compare
hirviid
requested changes
Dec 20, 2024
| ) { | ||
| setIsGroupPass(true); | ||
| } | ||
| }, [passHoldersData]); |
There was a problem hiding this comment.
Afgeleide van data bijhouden in local state is een anti-pattern in React, het is beter gewoon een lokale variabele te voorzien
const isGroupPass = passHoldersData?.data.member && passHoldersData.data.member.length === 0
| @@ -120,14 +136,19 @@ export const OpportunityState = ({ passholder }: OpportunityStateDateProps) => { | |||
| if (cardSystem) { | |||
| if (cardSystem.socialTariff) { | |||
There was a problem hiding this comment.
In 1 if steken?
if (cardSystem?.socialTariff) {
Nu was ik op zoek naar een else, maar is er niet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
StepperFieldcomponent, which is used to select a number within a specific range:Changed
Removed
Fixed
Ticket: #UPS-5301