Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/wid 246 #7

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Feature/wid 246 #7

wants to merge 10 commits into from

Conversation

brampauwelyn
Copy link
Collaborator

@brampauwelyn brampauwelyn commented Sep 17, 2019

Added

  • added package supertest
  • added test for the uit-articlelinker app itself
  • added testCdbid in config.json

Changed

  • exclude logger from tests
  • changed api in config

Fixed

  • fixed broken test

Ticket: https://jira.uitdatabank.be/browse/WID-246

});

test('should return article already up to date', done => {
const testUrl = "https://www.bruzz.be/mobiliteit/fietsverpleegster-na-aanrijding-op-haachtsesteenweg-overweeg-droom-op-te-bergen-2019-09";
Copy link
Contributor

@bertramakers bertramakers Sep 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests will fail if this article is not available anymore (temporarily or permanently)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They will also be relatively slow due to making HTTP requests, especially to external systems that might be slow at times.

@willaerk willaerk changed the base branch from master to main November 4, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants