Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added end-to-end test for ownership #958

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Added end-to-end test for ownership #958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5bd45a1
Add start of ownership test
Anahkiasen Nov 20, 2024
cf18752
Work on requesting ownership
Anahkiasen Nov 20, 2024
df7d517
Merge branch 'feature/III-6358' into feature/III-6417
Anahkiasen Nov 21, 2024
c6671f3
Add E2E test to add and remove ownership
Anahkiasen Nov 21, 2024
8cf6a0d
No braces I know
Anahkiasen Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/pages/organizers/[organizerId]/ownerships/OwnershipsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export const OwnershipsTable = ({ requests, renderActions }: Props) => {
const { t } = useTranslation();
return (
<Stack
role="table"
flex={1}
padding={4}
marginBottom={5}
Expand All @@ -42,6 +43,7 @@ export const OwnershipsTable = ({ requests, renderActions }: Props) => {
{requests.map((request) => (
<Inline
key={request.id}
role="row"
justifyContent="space-between"
alignItems="center"
paddingY={3}
Expand Down
127 changes: 83 additions & 44 deletions src/test/e2e/create-organizer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { faker } from '@faker-js/faker';
import { test } from '@playwright/test';
import { expect, test } from '@playwright/test';

const dummyOrganizer = {
name: faker.lorem.word(),
Expand All @@ -18,55 +18,94 @@ const dummyOrganizer = {
};

test('create an organizer', async ({ baseURL, page }) => {
await page.goto(`${baseURL}/organizers/create`);
let organizerUrl;

await page.getByLabel('Naam').click();
await page.getByLabel('Naam').fill(dummyOrganizer.name);
await page.getByLabel('Website', { exact: true }).click();
await page
.getByLabel('Website', { exact: true })
.fill(dummyOrganizer.website);
await page.getByRole('button', { name: 'Opslaan' }).click();
await test.step('Step 1: Create an organizer', async () => {
await page.goto(`${baseURL}/organizers/create`);

await page.getByRole('tab', { name: 'Beschrijving' }).click();
await page.getByLabel('rdw-editor').click();
await page.getByLabel('rdw-editor').fill(dummyOrganizer.description);
await page.getByLabel('Naam').click();
await page.getByLabel('Naam').fill(dummyOrganizer.name);
await page.getByLabel('Website', { exact: true }).click();
await page
.getByLabel('Website', { exact: true })
.fill(dummyOrganizer.website);
await page.getByRole('button', { name: 'Opslaan' }).click();

await page.getByRole('tab', { name: 'Contact' }).click();
await page.getByRole('button', { name: 'Contactgegevens toevoegen' }).click();
await page.locator('#contact-info-value-1').click();
await page.locator('#contact-info-value-1').fill(dummyOrganizer.email);
await page.locator('#contact-info-value-1').blur();
await page.getByRole('tab', { name: 'Beschrijving' }).click();
await page.getByLabel('rdw-editor').click();
await page.getByLabel('rdw-editor').fill(dummyOrganizer.description);

await page.getByRole('tab', { name: 'Labels' }).click();
await page.getByLabel('Verfijn met labels').click();
await page.getByLabel('Verfijn met labels').fill(dummyOrganizer.label);
await page.getByLabel(dummyOrganizer.label).click();
await page.getByText(dummyOrganizer.label).click();
await page.getByRole('tab', { name: 'Contact' }).click();
await page
.getByRole('button', { name: 'Contactgegevens toevoegen' })
.click();
await page.locator('#contact-info-value-1').click();
await page.locator('#contact-info-value-1').fill(dummyOrganizer.email);
await page.locator('#contact-info-value-1').blur();

await page.getByRole('tab', { name: 'Afbeeldingen' }).click();
await page.getByRole('button', { name: 'Afbeelding toevoegen' }).click();
await page.getByRole('button', { name: 'Kies bestand' }).click();
await page
.locator('input[type=file]')
.setInputFiles('./src/test/data/image.png');
await page.getByLabel('Beschrijving').click();
await page.getByLabel('Beschrijving').fill(dummyOrganizer.image.name);
await page.getByLabel('Copyright').click();
await page.getByLabel('Copyright').fill(dummyOrganizer.image.copyright);
await page.getByRole('button', { name: 'Uploaden' }).click();
await page.getByText(`© ${dummyOrganizer.image.copyright}`).click();
await page.getByRole('tab', { name: 'Labels' }).click();
await page.getByLabel('Verfijn met labels').click();
await page.getByLabel('Verfijn met labels').fill(dummyOrganizer.label);
await page.getByLabel(dummyOrganizer.label).click();
await page.getByText(dummyOrganizer.label).click();

await page.getByRole('tab', { name: 'Adres' }).click();
await page.getByLabel('Gemeente').click();
await page.getByLabel('Gemeente').fill(dummyOrganizer.location.municipality);
await page.getByLabel(dummyOrganizer.location.municipality).click();
const streetField = await page.getByLabel('Straat en nummer').nth(0);
await streetField.click();
await streetField.fill(dummyOrganizer.location.address);
await streetField.blur();
await page.getByRole('tab', { name: 'Afbeeldingen' }).click();
await page.getByRole('button', { name: 'Afbeelding toevoegen' }).click();
await page.getByRole('button', { name: 'Kies bestand' }).click();
await page
.locator('input[type=file]')
.setInputFiles('./src/test/data/image.png');
await page.getByLabel('Beschrijving').click();
await page.getByLabel('Beschrijving').fill(dummyOrganizer.image.name);
await page.getByLabel('Copyright').click();
await page.getByLabel('Copyright').fill(dummyOrganizer.image.copyright);
await page.getByRole('button', { name: 'Uploaden' }).click();
await page.getByText(`© ${dummyOrganizer.image.copyright}`).click();

await page.getByText('100/100').click();
await page.getByRole('tab', { name: 'Adres' }).click();
await page.getByLabel('Gemeente').click();
await page
.getByLabel('Gemeente')
.fill(dummyOrganizer.location.municipality);
await page.getByLabel(dummyOrganizer.location.municipality).click();
const streetField = await page.getByLabel('Straat en nummer').nth(0);
await streetField.click();
await streetField.fill(dummyOrganizer.location.address);
await streetField.blur();

await page.getByRole('button', { name: 'Klaar met bewerken' }).click();
await page.getByText('100/100').click();

await page
.getByRole('button', { name: 'Klaar met bewerken' })
.click({ force: true });

await page.waitForURL('**/preview**');
organizerUrl = await page.url();
});

await test.step('Step 2: can assign ownerships on organizer', async () => {
await page.goto(organizerUrl.replace('preview', 'ownerships'));

// Add ownership
await page
.getByRole('button', { name: 'Nieuwe beheerder toevoegen' })
.click();
await page.getByLabel('E-mailadres').fill(process.env.E2E_TEST_EMAIL);
await page.getByRole('button', { name: 'Beheerder toevoegen' }).click();
await expect(page.getByRole('dialog')).toBeHidden();
await expect(page.getByTestId('alert-success')).toContainText(
process.env.E2E_TEST_EMAIL,
);
await expect(
page.getByRole('row').getByText(process.env.E2E_TEST_EMAIL),
).toBeVisible();
await page.getByRole('row').getByRole('button').click();

// Delete ownership
await page.getByRole('button', { name: 'Beheerder verwijderen' }).click();
await expect(page.getByRole('dialog')).toBeHidden();
await expect(
page.getByRole('row').getByText(process.env.E2E_TEST_EMAIL),
).toBeHidden();
});
});
1 change: 1 addition & 0 deletions src/ui/Alert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ const Alert = ({
return (
<Inline
role="alert"
data-testid={`alert-${variant}`}
alignSelf={fullWidth ? 'normal' : 'flex-start'}
display={visible ? 'flex' : 'none'}
{...getStackProps(props)}
Expand Down
Loading