III-6151 fix timezone issues latest #946
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/hooks/api/events.ts
Did you find this useful? React with a 👍 or 👎 |
simon-debruijn
requested review from
brampauwelyn and
Anahkiasen
as code owners
|
The e2e tests also work when I set the global timezoneId to 'Asia/Tokyo'. |
brampauwelyn
approved these changes
Nov 6, 2024
| async (page) => { | ||
| await page.goto(url); | ||
| const startHour = page.getByLabel('Beginuur'); | ||
| expect(await startHour.inputValue({ timeout: 10_000 })).toEqual('01:00'); |
There was a problem hiding this comment.
It will always be 01:00 I guess?
Even if we change the timezone here to Tokyo?
Or will it display the time with the Tokyo timezine?
There was a problem hiding this comment.
The time should always show the time value you'd expect. SO indeed if the timezone is Tokyo or Brussels the time value should be 01:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed
Ticket: https://jira.uitdatabank.be/browse/III-6151