Added ability to leave street blank for organisers #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anahkiasen
requested review from
simon-debruijn and
brampauwelyn
as code owners
simon-debruijn
requested changes
Oct 8, 2024
There was a problem hiding this comment.
The e2e tests give a valid error
Error: locator.fill: Error: strict mode violation: getByLabel('Straat en nummer') resolved to 2 elements:
1) <input type="text" name="address.streetAndNumber" id="organizer-address-streetAndNumber" class="Box__StyledBox-sc-ogeep9-0 dTTsTB form-control"/> aka getByLabel('Straat en nummer', { exact: *** })
2) <input value="" type="checkbox" id="blank_address" name="blank_address" class="Box__StyledBox-sc-ogeep9-0 hiedRv custom-control-input"/> aka getByLabel('Ik wil mijn straat en nummer')
simon-debruijn
approved these changes
Oct 14, 2024
| @@ -51,9 +51,10 @@ test('create a place', async ({ baseURL, page }) => { | |||
| await page | |||
| .getByRole('option', { name: dummyPlace.address.municipality }) | |||
| .click(); | |||
| await page.getByLabel('Straat en nummer').click(); | |||
| await page.getByLabel('Straat en nummer').nth(0).click(); | |||
There was a problem hiding this comment.
I slightly prefer the first method
There was a problem hiding this comment.
What do you mean? 🤔
There was a problem hiding this comment.
I think the issue is maybe placing an actual field inside a field's info slot, which means the label applies to both. Like Playwright is correct that it's iffy. perhaps, I can find a way to work around it so that it's better from a semantics/a11y standpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Ticket: https://jira.publiq.be/browse/III-6231