Merge pull request #947 from cultuurnet/bugfix/III-6384-blank-street-…

…toggle
cultuurnet · Nov 14, 2024 · b2ba463 · b2ba463
2 parents 90cfd8a + 492a316
commit b2ba463
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 11 deletions.
diff --git a/package.json b/package.json
@@ -83,7 +83,7 @@
   },
   "devDependencies": {
     "@faker-js/faker": "^8.0.2",
-    "@playwright/test": "^1.31.2",
+    "@playwright/test": "1.31.2",
     "@storybook/addon-a11y": "^6.5.16",
     "@storybook/addon-actions": "^6.5.16",
     "@storybook/addon-essentials": "^6.5.16",

diff --git a/src/pages/steps/LocationStep.tsx b/src/pages/steps/LocationStep.tsx
@@ -268,7 +268,6 @@ export const BlankStreetToggle = ({
 
   return (
     <RadioButtonWithLabel
-      id={'blank_address'}
       name={'blank_address'}
       label={
         <Text className={'ml-1'}>
@@ -708,14 +707,16 @@ const LocationStep = ({
                           t('location.add_modal.errors.streetAndNumber')
                         }
                         info={
-                          <BlankStreetToggle
-                            onChange={(streetAndNumber) =>
-                              onFieldChange({
-                                streetAndNumber,
-                                location: { streetAndNumber },
-                              })
-                            }
-                          />
+                          scope === ScopeTypes.ORGANIZERS && (
+                            <BlankStreetToggle
+                              onChange={(streetAndNumber) =>
+                                onFieldChange({
+                                  streetAndNumber,
+                                  location: { streetAndNumber },
+                                })
+                              }
+                            />
+                          )
                         }
                       />
                     </Stack>

diff --git a/src/test/e2e/create-place.spec.ts b/src/test/e2e/create-place.spec.ts
@@ -51,6 +51,7 @@ test('create a place', async ({ baseURL, page }) => {
   await page
     .getByRole('option', { name: dummyPlace.address.municipality })
     .click();
+  await expect(page.getByLabel('blank_address')).not.toBeVisible();
   await page.getByLabel('Straat en nummer').nth(0).click();
   await page
     .getByLabel('Straat en nummer')

diff --git a/yarn.lock b/yarn.lock
@@ -1767,7 +1767,7 @@
     tiny-glob "^0.2.9"
     tslib "^2.4.0"
 
-"@playwright/test@^1.31.2":
+"@playwright/[email protected]":
   version "1.31.2"
   resolved "https://registry.yarnpkg.com/@playwright/test/-/test-1.31.2.tgz#426d8545143a97a6fed250a2a27aa1c8e5e2548e"
   integrity sha512-BYVutxDI4JeZKV1+ups6dt5WiqKhjBtIYowyZIJ3kBDmJgsuPKsqqKNIMFbUePLSCmp2cZu+BDL427RcNKTRYw==