PPF-55 Send mail when integration is blocked #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 20, 2024 14:35
grubolsch
requested review from
LucWollants,
JonasVHG,
brampauwelyn,
simon-debruijn,
vhande,
Anahkiasen and
dev-publiq
as code owners
Base automatically changed from
PPF-56/activate-mail
to
PPF-56/mail-sent-basis
August 21, 2024 07:11
grubolsch
changed the title
PPF-55 Moved classes around related to Mailjet / Sending mail
LucWollants
reviewed
Aug 22, 2024
| 'url' => $this->baseUrl . '/nl/integraties/' . $integration->id, | ||
| 'type' => $integration->type->value, | ||
| ] | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| public function sendIntegrationBlockedMail(IntegrationBlocked $integrationBlocked): void |
There was a problem hiding this comment.
Is the direct URL of the integration inside publiq-platform useful for every type of mail?
There was a problem hiding this comment.
Difficult to say because we don't have a final copy of these emails.
Currently I am just using it for the activation email, but we will have to see how it ends up.
Would you prefer to always send all variables?
There was a problem hiding this comment.
It's easy to change later, but I thought it would be useful to be able to always open the integration from the mail the integrator received. Makes it less of a hassle to find the integration in question.
LucWollants
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Sent mail when integration is blocked
Ticket: https://jira.uitdatabank.be/browse/PPF-55