PPF-562 Create helper method to activate uitpas integration with organizers #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grubolsch
requested review from
LucWollants,
JonasVHG,
brampauwelyn,
simon-debruijn,
vhande,
Anahkiasen and
dev-publiq
as code owners
LucWollants
reviewed
Aug 6, 2024
LucWollants
reviewed
Aug 6, 2024
| @@ -115,15 +129,25 @@ public function activate(UuidInterface $id): void | |||
| $integrationModel->activate(); | |||
| } | |||
|
|
|||
| public function activateWithOrganization(UuidInterface $id, UuidInterface $organizationId, ?string $couponCode): void | |||
| public function activateWithOrganization(UuidInterface $integrationId, UuidInterface $organizationId, ?string $couponCode, array $organizers=[]): void | |||
There was a problem hiding this comment.
Should this also be typed on the new collection?
There was a problem hiding this comment.
I thought so to at first but if you look at ActivateIntegration you can see that actually it is an array of strings (ids).
I will add a docblock to make this more clear.
There was a problem hiding this comment.
But should it be an array of strings? The UdbOrganizers could be created where this gets called. So in the handle method of ActivateUitpasIntegration the construction of UdbOrganizer could be done.
There was a problem hiding this comment.
Moved it to the ActivateUitpasIntegration class
LucWollants
reviewed
Aug 6, 2024
app/Domain/Integrations/Repositories/EloquentUdbOrganizerRepository.php
Outdated
Show resolved
Hide resolved
LucWollants
reviewed
Aug 6, 2024
…pas-integration-with-organizers
|
Feedback has been processed |
LucWollants
reviewed
Aug 6, 2024
LucWollants
approved these changes
Aug 6, 2024
grubolsch
deleted the
PPF-562/create-helper-method-to-activate-uitpas-integration-with-organizers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed
Ticket: https://jira.uitdatabank.be/browse/PPF-562