Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PPF-557 - Don't prefill subscriptionId when it is falsy #1269

Merged
merged 3 commits into from
Jul 15, 2024
Merged

PPF-557 - Don't prefill subscriptionId when it is falsy #1269

merged 3 commits into from
Jul 15, 2024

Conversation

simon-debruijn
Copy link
Contributor

@simon-debruijn simon-debruijn commented Jul 12, 2024 •
edited
Loading

Changed

Fixed

  • when validation on another field wasn't successful the priceplan would get cleared, instead we wan't it to remain the same value as before the submit

Ticket: https://jira.uitdatabank.be/browse/PPF-557

@simon-debruijn simon-debruijn enabled auto-merge July 15, 2024 07:36
@simon-debruijn simon-debruijn merged commit 22dae54 into main Jul 15, 2024
8 checks passed
@simon-debruijn simon-debruijn deleted the PPF-557-fix-price-plan-field-on-validation-error branch July 15, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brampauwelyn brampauwelyn brampauwelyn approved these changes

@LucWollants LucWollants Awaiting requested review from LucWollants LucWollants is a code owner

@JonasVHG JonasVHG Awaiting requested review from JonasVHG JonasVHG is a code owner

@vhande vhande Awaiting requested review from vhande vhande is a code owner

@grubolsch grubolsch Awaiting requested review from grubolsch grubolsch is a code owner

@Anahkiasen Anahkiasen Awaiting requested review from Anahkiasen Anahkiasen is a code owner

@dev-publiq dev-publiq Awaiting requested review from dev-publiq dev-publiq is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon-debruijn @brampauwelyn