PPF-555 For uitpas integration always use key visibility v2 #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grubolsch
requested review from
LucWollants,
JonasVHG,
brampauwelyn,
simon-debruijn,
vhande,
Anahkiasen and
dev-publiq
as code owners
simon-debruijn
approved these changes
Jul 9, 2024
| IntegrationStatus::Draft, | ||
| IntegrationPartnerStatus::FIRST_PARTY, | ||
| ); | ||
| $searchIntegration = $searchIntegration->withKeyVisibility(KeyVisibility::v1); |
There was a problem hiding this comment.
I'm wondering if this should maybe throw an exception instead of magically setting the visibility differently than expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
For UiTPAS API integration, the key visiblity must always be v2
As discussed with Corneel, this is only changed for Integrations created in the frontend.
Ticket: https://jira.uitdatabank.be/browse/PPF-555