PPF-553 BUGFIX Organizers gives 409 in admin panel #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grubolsch
requested review from
LucWollants,
JonasVHG,
brampauwelyn,
simon-debruijn,
vhande,
Anahkiasen and
dev-publiq
as code owners
JonasVHG
approved these changes
Jul 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
The UiTdatabank organizers linked to an UiTPAS integration do not load in the admin panel. (409 error).
The problem is that on this API call the $resource is not loaded in the IntegrationModel (aka the fields).
This means that the method isUitpas() always returns false, because the $type is not set.
As a (quick) fix I set the default value of type to Uitpas.
On the UI overview pages the Integration is loaded in, so this overwrites the default value.
Know problem: When creating an integration in the Admin UI the Type is as a default Uitpas
Known Limitation: If we ever have 2 different values in type that toggle conditions, we have a problem.
Ticket: https://jira.uitdatabank.be/browse/PPF-553