PPF-523 Deleting integration should block keycloak clients #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grubolsch
requested review from
LucWollants,
JonasVHG,
brampauwelyn,
simon-debruijn,
vhande,
Anahkiasen and
dev-publiq
as code owners
LucWollants
reviewed
Jun 18, 2024
| { | ||
| $integration = $this->integrationRepository->getById($integrationBlocked->id); |
There was a problem hiding this comment.
FYI: it's fine like it is now, but there is a getByIdWithTrashed to get deleted integration.
There was a problem hiding this comment.
Ahh, thank you for that info, but we also don't use anything from the integration except the id so fetching it doesn't have any added value.
LucWollants
reviewed
Jun 18, 2024
| private readonly KeycloakClientRepository $keycloakClientRepository, | ||
| private readonly ApiClient $client, | ||
| private readonly LoggerInterface $logger | ||
| ) { | ||
| } | ||
|
|
||
| public function handle(IntegrationBlocked $integrationBlocked): void | ||
| public function handle(IntegrationBlocked|IntegrationDeleted $integrationBlocked): void |
There was a problem hiding this comment.
Maybe use a more generic name for the parameter?
LucWollants
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed
BlockClients no longer fetches the integration but just uses the integration id.
Ticket: https://jira.uitdatabank.be/browse/PPF-523