PPF-510 Make scopeConfig dependent on chosen realm #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grubolsch
requested review from
LucWollants,
JonasVHG,
brampauwelyn,
simon-debruijn,
vhande,
Anahkiasen and
dev-publiq
as code owners
LucWollants
approved these changes
Jun 10, 2024
LucWollants
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed
Context
Currently we assumed 1 keycloak instance running multiple realms (acc, test, prod).
After a conversation with Erwin this was confirmed as false - each environment will have it's own instance. This will contain 2 realms, a master realm and a realm for acc OR test OR prod.
We already updated the code to have different urls/client/secrets per environment.
We also need it to be possible to have different scope ids per environment.
Related pr
https://github.com/cultuurnet/appconfig/pull/660
Ticket: https://jira.uitdatabank.be/browse/PPF-510