Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPF-493 Make realm contain the api uri #1162

Merged

Conversation

grubolsch
Copy link
Contributor

@grubolsch grubolsch commented May 30, 2024

Context

Currently we assumed 1 keycloak instance running multiple realms (acc, test, prod).

After a conversation with Erwin this was confirmed as false - each environment will have it's own instance. This will contain 2 realms, a master realm and a realm for acc OR test OR prod.

Consequences:

The URI has to be moved from the Config to the Realm object
The ScopeConfig should be dependent on the chosen Realm
When working with the master realm for requesting the token, the correct environment has to be given.

Changed

  • The URI and secret was moved from the Config to the Realm object
  • When working with the master realm for requesting the token, the correct environment matching the original realm is given. (for example a request from Test should contact the Master on test server).
  • MINOR - Made names of environments (acc, test, prod) consistent with the other clients (uitid, auth0).
  • MINOR - Always use id instead of client id for API calls.

Not in this PR

The ScopeConfig should be dependent on the chosen Realm
ClientId should be a string not a UUID because of migration from auth0.

Config changes PR

https://github.com/cultuurnet/appconfig/pull/645


Ticket: https://jira.uitdatabank.be/browse/PPF-493

@grubolsch grubolsch requested a review from LucWollants May 30, 2024 14:09
@grubolsch grubolsch requested a review from LucWollants June 6, 2024 12:34
Koen Eelen and others added 5 commits June 7, 2024 10:13
@grubolsch grubolsch requested a review from LucWollants June 7, 2024 08:31
@grubolsch grubolsch merged commit b4eeff5 into PPF-434/keycloak-integration Jun 7, 2024
8 checks passed
@grubolsch grubolsch deleted the PPF-493/Make-Realm-contain-the-API-uri branch June 7, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants