-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPF-493 Make realm contain the api uri #1162
Merged
grubolsch
merged 38 commits into
PPF-434/keycloak-integration
from
PPF-493/Make-Realm-contain-the-API-uri
Jun 7, 2024
Merged
PPF-493 Make realm contain the api uri #1162
grubolsch
merged 38 commits into
PPF-434/keycloak-integration
from
PPF-493/Make-Realm-contain-the-API-uri
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grubolsch
requested review from
LucWollants,
JonasVHG,
brampauwelyn,
simon-debruijn,
vhande,
Anahkiasen and
dev-publiq
as code owners
May 30, 2024 09:45
LucWollants
reviewed
May 30, 2024
LucWollants
reviewed
May 30, 2024
LucWollants
reviewed
May 30, 2024
LucWollants
reviewed
May 30, 2024
LucWollants
reviewed
May 30, 2024
LucWollants
reviewed
May 30, 2024
LucWollants
reviewed
Jun 6, 2024
LucWollants
reviewed
Jun 6, 2024
LucWollants
reviewed
Jun 6, 2024
…eycloak-clients PPF-493 Integration expose keycloak clients
…ultuurnet/publiq-platform into PPF-493/Make-Realm-contain-the-API-uri
LucWollants
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently we assumed 1 keycloak instance running multiple realms (acc, test, prod).
After a conversation with Erwin this was confirmed as false - each environment will have it's own instance. This will contain 2 realms, a master realm and a realm for acc OR test OR prod.
Consequences:
The URI has to be moved from the Config to the Realm object
The ScopeConfig should be dependent on the chosen Realm
When working with the master realm for requesting the token, the correct environment has to be given.
Changed
Not in this PR
The ScopeConfig should be dependent on the chosen Realm
ClientId should be a string not a UUID because of migration from auth0.
Config changes PR
https://github.com/cultuurnet/appconfig/pull/645
Ticket: https://jira.uitdatabank.be/browse/PPF-493