PPF-436 Create listeners #1103
Merged
PPF-436 Create listeners #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grubolsch
requested review from
LucWollants,
JonasVHG,
brampauwelyn,
simon-debruijn,
vhande,
Anahkiasen and
dev-publiq
as code owners
added 16 commits
May 16, 2024 10:02
added 4 commits
May 16, 2024 10:03
…iq-platform into PPF-436/create-listeners
added 7 commits
May 17, 2024 10:40
LucWollants
reviewed
May 21, 2024
LucWollants
reviewed
May 21, 2024
LucWollants
reviewed
May 21, 2024
|
|
||
| private function applyEvents(): void | ||
| { | ||
| if (!$this->app->get(Config::class)->isEnabled) { |
There was a problem hiding this comment.
Nit: It is also possible to create the Config class on the stack on line 40 and then pass it in here. But both are fine.
LucWollants
reviewed
May 21, 2024
LucWollants
reviewed
May 21, 2024
LucWollants
approved these changes
May 21, 2024
added 2 commits
May 21, 2024 10:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
This PR adds the listener when an integration is created, to automatically create the integration.
Ticket: https://jira.uitdatabank.be/browse/PPF-436