Improve copy client credentials switch #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneelwille
changed the title
uitid_alert
vhande
requested review from
LucWollants,
JonasVHG,
brampauwelyn,
simon-debruijn,
vhande,
grubolsch,
Anahkiasen and
dev-publiq
as code owners
simon-debruijn
approved these changes
Apr 19, 2024
| @@ -219,8 +219,8 @@ | |||
| "test": "Test", | |||
| "live": "Live", | |||
| "status_alert": "Approval from publiq is necessary for the live integration of this project. All information to smoothly go live can be found", | |||
| "link": "here", | |||
| "uitid_alert": "Client credentials have not yet been requested for this integration.", | |||
| "uitid_alert": "You can switch to authentication with client credentials. Check <0>here</0> whether this method of authentication is suitable for your application. Once you have requested client credentials, your API key remains valid for another 6 months.", | |||
There was a problem hiding this comment.
In the backend the 6 months (180 days) is configurable via config. Should this copy also depend on a config value in the frontend?
| @@ -219,8 +219,8 @@ | |||
| "test": "Test", | |||
| "live": "Live", | |||
| "in_progress": "Je aanvraag tot activatie is in behandeling.", | |||
| "link": "here", | |||
| "uitid_alert": "Voor deze integratie zijn nog geen Client credentials aangevraagd.", | |||
| "uitid_alert": "Je kan de overstap maken naar authenticatie met client credentials. Bekijk <0>hier</0> of deze manier van authenticatie geschikt is voor jouw applicatie. Eens je client credentials aangevraagd hebt, blijft je API key nog 6 maanden geldig.", | |||
resources/ts/Components/Integrations/Detail/CredentialsAuthClients.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
uitid_alertTicket: https://jira.uitdatabank.be/browse/PPF-418