Merge pull request #1130 from cultuurnet/feature/PPF-457

cultuurnet · May 23, 2024 · 8b4ddbd · 8b4ddbd
2 parents 47f7acf + fc3bd47
commit 8b4ddbd
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 12 deletions.
diff --git a/.env.example b/.env.example
@@ -152,3 +152,5 @@ E2E_TEST_PASSWORD=
 E2E_TEST_ADMIN_EMAIL=[email protected]
 E2E_TEST_ADMIN_PASSWORD=
 
+UITPAS_INTEGRATION_TYPE_ENABLED=true
+VITE_UITPAS_INTEGRATION_TYPE_ENABLED=${UITPAS_INTEGRATION_TYPE_ENABLED}
diff --git a/resources/ts/Components/IntegrationCard.tsx b/resources/ts/Components/IntegrationCard.tsx
@@ -29,7 +29,7 @@ type Props = Integration &
   };
 
 const productTypeToPath = {
-  "uitpas-api": "/",
+  uitpas: "/",
   "entry-api": "/uitdatabank/entry-api/introduction",
   "search-api": "/uitdatabank/search-api/introduction",
   widgets: "/widgets/aan-de-slag",

diff --git a/resources/ts/Components/IntegrationTypes.tsx b/resources/ts/Components/IntegrationTypes.tsx
@@ -80,23 +80,25 @@ export const getIntegrationTypesInfo = (t: TFunction) => [
 export const useIntegrationTypesInfo = () => {
   const { t } = useTranslation();
 
-  return useMemo(() => getIntegrationTypesInfo(t), [t]);
+  return useMemo(() => {
+    const integrationTypesInfo = getIntegrationTypesInfo(t);
+
+    // See https://jira.publiq.be/browse/PPF-481
+    return uitpasEnabled
+      ? integrationTypesInfo
+      : integrationTypesInfo.filter(
+          (integrationTypesInfo) =>
+            integrationTypesInfo.type !== IntegrationType.UiTPAS
+        );
+  }, [t]);
 };
 
 export type IntegrationTypesInfo = ReturnType<
   typeof getIntegrationTypesInfo
 >[number];
 
 export const IntegrationTypes = () => {
-  const integrationTypesInfo = useIntegrationTypesInfo();
-
-  // See https://jira.publiq.be/browse/PPF-481
-  const filteredIntegrationTypes = uitpasEnabled
-    ? integrationTypesInfo
-    : integrationTypesInfo.filter(
-        (integrationTypesInfo) =>
-          integrationTypesInfo.type !== IntegrationType.UiTPAS
-      );
+  const filteredIntegrationTypes = useIntegrationTypesInfo();
 
   return (
     <div>

diff --git a/resources/ts/types/IntegrationType.ts b/resources/ts/types/IntegrationType.ts
@@ -4,7 +4,7 @@ export const IntegrationType = {
   EntryApi: "entry-api",
   SearchApi: "search-api",
   Widgets: "widgets",
-  UiTPAS: "uitpas-api",
+  UiTPAS: "uitpas",
 } as const;
 
 export type IntegrationType = Values<typeof IntegrationType>;