Skip to content

Commit

Permalink
fix # for logout urls
Browse files Browse the repository at this point in the history
  • Loading branch information
Koen Eelen committed Jun 28, 2024
1 parent bb2fd05 commit 68517b2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/Keycloak/Converters/IntegrationUrlConverter.php
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@ public static function buildLogoutUrls(Integration $integration, Environment $en
}

$logoutUrls = $integration->urlsForTypeAndEnvironment(IntegrationUrlType::Logout, $environment);
return implode('#', array_map(static fn ($url) => $url->url, $logoutUrls));
return implode('##', array_map(static fn ($url) => $url->url, $logoutUrls));
}
}
2 changes: 1 addition & 1 deletion tests/Keycloak/Converters/IntegrationUrlConverterTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public function test_convert_for_first_party_logout_urls(): void
new IntegrationUrl(Uuid::uuid4(), $integration->id, Environment::Production, IntegrationUrlType::Logout, 'https://wrong.com/'),
);
$this->assertSame(
'https://example.com/logout1#https://example.com/logout2',
'https://example.com/logout1##https://example.com/logout2',
IntegrationUrlConverter::buildLogoutUrls($integration, $this->client->environment)
);
}
Expand Down

0 comments on commit 68517b2

Please sign in to comment.