Merge pull request #1228 from cultuurnet/PPF-525/logout-url-fix

PPF-525 Fix # for logout urls
cultuurnet · Jun 28, 2024 · 22c1d49 · 22c1d49
2 parents 17a49d0 + bb81fec
commit 22c1d49
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/app/Keycloak/Converters/IntegrationUrlConverter.php b/app/Keycloak/Converters/IntegrationUrlConverter.php
@@ -54,6 +54,6 @@ public static function buildLogoutUrls(Integration $integration, Environment $en
         }
 
         $logoutUrls = $integration->urlsForTypeAndEnvironment(IntegrationUrlType::Logout, $environment);
-        return implode('#', array_map(static fn ($url) => $url->url, $logoutUrls));
+        return implode('##', array_map(static fn ($url) => $url->url, $logoutUrls));
     }
 }
diff --git a/tests/Keycloak/Converters/IntegrationToKeycloakClientConverterTest.php b/tests/Keycloak/Converters/IntegrationToKeycloakClientConverterTest.php
@@ -83,7 +83,7 @@ public function test_combining_keycloak_convert_with_configured_uris(): void
         $this->assertEquals([
             'origin' => 'publiq-platform',
             'use.refresh.tokens' => true,
-            'post.logout.redirect.uris' => 'https://example.com/logout1#https://example.com/logout2',
+            'post.logout.redirect.uris' => 'https://example.com/logout1##https://example.com/logout2',
         ], $convertedData['attributes']);
         $this->assertEquals('https://example.com/login1', $convertedData['baseUrl']);
         $this->assertEquals(['https://example.com/callback1', 'https://example.com/callback2'], $convertedData['redirectUris']);

diff --git a/tests/Keycloak/Converters/IntegrationUrlConverterTest.php b/tests/Keycloak/Converters/IntegrationUrlConverterTest.php
@@ -99,7 +99,7 @@ public function test_convert_for_first_party_logout_urls(): void
             new IntegrationUrl(Uuid::uuid4(), $integration->id, Environment::Production, IntegrationUrlType::Logout, 'https://wrong.com/'),
         );
         $this->assertSame(
-            'https://example.com/logout1#https://example.com/logout2',
+            'https://example.com/logout1##https://example.com/logout2',
             IntegrationUrlConverter::buildLogoutUrls($integration, $this->client->environment)
         );
     }