Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WID-575 #417

Merged
merged 12 commits into from
Aug 6, 2024
Merged

WID-575 #417

merged 12 commits into from
Aug 6, 2024

Conversation

JonasVHG
Copy link
Contributor

@JonasVHG JonasVHG commented Aug 5, 2024

Added

  • autocompletemini.json: sample autocomplete file to use in tests
  • RegionServicetest: Unit Tests for the RegionService

Changed

  • RegionService: Refactor logic of getAutocompletResults() to show both short municipality names & submunicipalities.

Removed

  • RegionService: removed function sortByLevenshtein(), since it is no longer used.

Fixed

  • Cities & towns(Zele, Egem,...) with short names, should now be found in the autocomplete.

Ticket: https://jira.publiq.be/browse/WID-575

@JonasVHG JonasVHG marked this pull request as ready for review August 5, 2024 08:00
@JonasVHG JonasVHG requested a review from LucWollants August 6, 2024 09:01
@JonasVHG JonasVHG merged commit 7ff500b into master Aug 6, 2024
1 check passed
@JonasVHG JonasVHG deleted the WID-575 branch August 6, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants