Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No inlangage in schema #92

Closed
MaudeFJ opened this issue Sep 26, 2024 · 14 comments
Closed

No inlangage in schema #92

MaudeFJ opened this issue Sep 26, 2024 · 14 comments
Assignees
Labels
Signé Laval Issues reported on Singé Laval's website

Comments

@MaudeFJ
Copy link

MaudeFJ commented Sep 26, 2024

@sahalali @AbhishekPAnil this request is to configure the Signe Laval calendar Events to automatically set the in language taxonomy to French and have it be displayed in the Event form.

Details:
Signe Laval would like all events to be automatically set to French language.
To do this going forward, all new events in the Signe Laval event form should always display the in Language field in the event form and French should be prefilled.
Then the user can edit and do two things:

  • add additional langauges that are listed in the taxonomomy as they need (for example, they can add spanish, english etc)
  • remove french if they want.

Additional request: For ALL existing events, add French to in language field, do not overwrite other languages if they are already selected.

Request from Maude, our client:
Hello, i realized that the in langage is not there when I validate the events in my calendar :
https://validator.schema.org/#url=https%3A%2F%2Fsignelaval.com%2Ffr%2Fevenements%2F66da98c8345131006449a596%2Fheure-du-conte-bilingue-francais-espagnol
https://schema.org/inLanguage
Is it possible to just put french for all event and put the other language that is selected with the language taxonomies I created ?
This is not urgent, but I'm just putting it here! thanks

@troughc
Copy link

troughc commented Sep 26, 2024

@MaudeFJ, hmm, to add French as the language of all your events, you would probably first need to have it in your "in language" taxonomy. Then, you could apply it to all your events.
@saumier, what do you think?, is that right?
If I understand Maude correctly, she would like of the language of all her events to automatically be set to French. My thought was, French has to be part of the in language taxonomy, before we could even do this as a special configuration (automatically adding a property that denotes french as the language of all events.
In language property/field would then always be displayed in the UI for, at minimum, the Admin (by restricting the view).

@saumier
Copy link
Member

saumier commented Sep 30, 2024

@troughc Yes, the taxonomy for 'inLanguage' should have French. I looked and there is French in the taxonomy for inLanguage on Signé Laval.

@saumier saumier assigned troughc and unassigned saumier Sep 30, 2024
@MaudeFJ
Copy link
Author

MaudeFJ commented Sep 30, 2024 via email

@troughc troughc assigned sahalali and unassigned troughc Sep 30, 2024
@troughc troughc added the Signé Laval Issues reported on Singé Laval's website label Sep 30, 2024
@troughc troughc assigned saumier and MaudeFJ and unassigned sahalali Sep 30, 2024
@troughc
Copy link

troughc commented Sep 30, 2024

@MaudeFJ @saumier can you please review the description at the top? (first comment). Let me know if there are any issues. thanks.

@saumier
Copy link
Member

saumier commented Oct 1, 2024

@troughc Here is my feedback

Signe Laval would like all events to be automatically set to French language.

This sounds like a new feature to be added to CMS. The new feature would allow the admin to select a default for a taxonomy.

For manual data entry: if the taxonomy is configured in the calendar settings to be mandatory, and there is a default value set in the Taxonomy, then it should be pre-filled.
For aggregating events: if the taxonomy is configured in the calendar settings to be mandatory, and there is a default value set in the Taxonomy, then if the field is empty it should be set to the default.

Additional request. For ALL existing events, add French to in language field, do not overwrite other languages if they are already selected.

This can be done with the bulk download and upload.

@troughc troughc assigned sahalali and AbhishekPAnil and unassigned saumier and MaudeFJ Oct 1, 2024
@troughc troughc added the estimate needed This should be estimated by a developer so it can prioritised label Oct 10, 2024
@AbhishekPAnil
Copy link

Frontend tasks : 1h
1.For unilingual calendars ,prefill new events with inLanguage taxonomy with the respective content language ,if it exists .

@AbhishekPAnil AbhishekPAnil removed their assignment Oct 11, 2024
@sahalali
Copy link

sahalali commented Oct 11, 2024

@AbhishekPAnil The above solution will make the events fragile and will be hard to implement.

Proposed solution:

  1. We need to add a new configuration to the calendars to set the default inLanguage. This option should be available on the calendar settings page, allowing users to select a taxonomy and a default concept from the taxonomy.

In the future, it would be helpful to have an option to directly map the taxonomy to a Schema.org class or property. For example, mapping a taxonomy with https://schema.org/inLanguage.

How is this useful? In this case, the user won't have to select a taxonomy first and then the concept. Instead, they can select concepts from a taxonomy mapped to https://schema.org/inLanguage.
2. When a user creates/updates events without an inLanguage, add the default concept to the event.

Note: Currently, we can also start with just making changes in backed alone.

Estimation: 8 hours (backend)
@AbhishekPAnil Can you estimate the front end effort?

@sahalali sahalali assigned troughc and unassigned sahalali Oct 11, 2024
@AbhishekPAnil
Copy link

Frontend tasks modified: 11h
1.Add the field to select default inLangage in calendar settings page.
2.Api integration for getting inLangage taxonomy.
3.Prefill new events with the default inlanguage taxonomy.
4.Api integration for saving the inLanguage in calendar settings

@AbhishekPAnil AbhishekPAnil added to be scheduled Issue has been estimated, now it needs to be planned. and removed estimate needed This should be estimated by a developer so it can prioritised labels Oct 11, 2024
@troughc
Copy link

troughc commented Oct 11, 2024

Caitlin and Suhail to discuss Tuesday. Caitlin to review comment

@troughc
Copy link

troughc commented Oct 16, 2024

Plan:

  1. make a custom change in the BE to configure this for Signe Laval (set French to be the default language of the event for every new event created, including those imported by aggregators)
  2. make a chnage in the FE to display the language of the event as French right from the beginning (creation step).
  3. Apply a migration script to add the default value (French in language) for existing events that do NOT already have a 'language of the event' concept applied.

Estimate is 6-8 hours

@sahalali sahalali assigned saumier and unassigned troughc and sahalali Oct 21, 2024
@saumier saumier assigned troughc and unassigned saumier Oct 21, 2024
@troughc troughc removed the to be scheduled Issue has been estimated, now it needs to be planned. label Oct 23, 2024
@troughc
Copy link

troughc commented Oct 23, 2024

@sahalali test results in production against these expected results:

  1. make a custom change in the BE to configure this for Signe Laval (set French to be the default language of the event for every new event created, including those imported by aggregators)

  2. make a change in the FE to display the language of the event as French right from the beginning (creation step).

  3. Apply a migration script to add the default value (French in language) for existing events that do NOT already have a 'language of the event' concept applied.

  4. Signe Laval seems to be configured in the BE to set french as the default language: PASSED

  5. When I create a new event in production, the default language is set to french: PASSED

  6. Apply a migration script to add the default value (French in language) for existing events that do NOT already have a 'language of the event' concept applied. This does not seem to be implemented

Question: I cannot confirm that new events coming from aggregators are getting the default language tag because the most recent date an event was created from an aggregator is October 4. Can you please confirm that aggregator events are being set to French by default?

@troughc
Copy link

troughc commented Oct 24, 2024

Regarding my question above:
Question: I cannot confirm that new events coming from aggregators are getting the default language tag because the most recent date an event was created from an aggregator is October 4. Can you please confirm that aggregator events are being set to French by default?

I saw that the new events that came in from Ville Laval had the French language tag, so that is working well from what I can tell. :)

@sahalali sahalali removed their assignment Oct 29, 2024
@sahalali
Copy link

Migrated all existing Signe-Laval events that did not have a specified language to French.

@troughc
Copy link

troughc commented Oct 29, 2024

Thank you team. PASSED!
I am closing this issue.

@troughc troughc closed this as completed Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Signé Laval Issues reported on Singé Laval's website
Projects
None yet
Development

No branches or pull requests

5 participants