Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated font style to only affect calendar widget and its children #47

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

SyamBabu-M
Copy link
Contributor

No description provided.

syam babu added 4 commits October 11, 2024 14:30
… fallback to Roboto

- Added try-catch block for robust error handling during font injection
- Implemented onerror event for font link element to handle loading failures
- Introduced fallback mechanism to apply 'Roboto' font if the requested font fails to load
- Ensured fallback applies if #calendar-widget is not found in the DOM
- Removed all font inherits and replaced with dynamically added css font variable
Copy link
Member

@saumier saumier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. I reviewed quickly but I don't have the background to really know if this is right. So I propose we move forward as we are in early stage with integration for Osaka and we can still do some iterations.

@saumier saumier merged commit 0789d82 into main Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants