Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Taxonomy concepts with multiple languages #1302

Closed
troughc opened this issue Sep 5, 2024 · 12 comments · Fixed by #1427
Closed

Enhancement: Taxonomy concepts with multiple languages #1302

troughc opened this issue Sep 5, 2024 · 12 comments · Fixed by #1427
Assignees
Labels
enhancement New feature or request To be deployed

Comments

@troughc
Copy link
Contributor

troughc commented Sep 5, 2024

This is an enhancement following up on #1189 (multiple language support).
Please refer to Figma titled "Taxonomy concepts - Spreadsheet approach - Updates to multiple languages" found here

This will be a significant change as the user will now do editing directly in the fields (No popup).

@SyamBabu-M
Copy link
Contributor

@troughc This new design will need a complete rework of the concepts section.
My estimate is 180 hours, this includes research time into new components as there are limitations for the current Antd component we are using.

@SyamBabu-M SyamBabu-M added to be scheduled Work has been estimated, now it needs a priority and milstone and removed estimate needed Add estimate for planning labels Oct 7, 2024
@SyamBabu-M SyamBabu-M assigned troughc and unassigned SyamBabu-M Oct 7, 2024
@SyamBabu-M
Copy link
Contributor

1 - Edit card UI design and integration into tree - 24h
2 - Language literal - 32h
3 - New drag and drop feature - need research
4 - styling - 8h

@troughc troughc removed the to be scheduled Work has been estimated, now it needs a priority and milstone label Oct 9, 2024
@troughc troughc assigned SyamBabu-M and unassigned troughc Oct 9, 2024
@troughc
Copy link
Contributor Author

troughc commented Oct 9, 2024

@SyamBabu-M FYI: after our discussion, I asked Stephanie to increase the space (margin) between the language literal tag and the next column/cell. She adjusted it in the figma

@troughc troughc assigned troughc and SyamBabu-M and unassigned SyamBabu-M and troughc Oct 9, 2024
@SyamBabu-M SyamBabu-M assigned dev-aravind and unassigned SyamBabu-M Nov 5, 2024
@SyamBabu-M SyamBabu-M linked a pull request Nov 5, 2024 that will close this issue
@dev-aravind
Copy link
Contributor

Hi @SyamBabu-M

I encountered 2 bugs here

1 - not able to drop a concept as a child to another concept unless it already has child concepts. The interaction works fine if there are already child concepts.
2 - color during the hover movement is not consistent

@dev-aravind dev-aravind assigned SyamBabu-M and unassigned dev-aravind Nov 5, 2024
@SyamBabu-M SyamBabu-M assigned troughc and unassigned SyamBabu-M Nov 14, 2024
@troughc
Copy link
Contributor Author

troughc commented Nov 14, 2024

it's looking really good. Just a few things.
When you expand a group, the language literal isn't showing up:

Screenshot 2024-11-14 at 2 11 29 PM

Can you make the blue dotted line the same colour as the Footlight colour ("Content Action Darker" in the figma)

**Is it possible to wrap text that doesn't fit in the field? You can see 2 things in the following screenshot

  • text doesn't wrap
  • the language literal is overtop of the text (instead of beside it)**
Screenshot 2024-11-14 at 2 00 33 PM

For example, in the dropdown for the field in the event, the text does wrap - this works well.

Screenshot 2024-11-14 at 2 01 33 PM

We can discuss different ways of solving this.

@troughc
Copy link
Contributor Author

troughc commented Nov 15, 2024

Sorry, I forgot to ask for the ability to delete a concept. can you add a delete button/dropdown menu on the right as a quick fix before we move to the next stage of develping this feature.
Also, remember to keep the current functionality of what happens when you delete a concept (the warning popup).
And to make a bit more space around the +/- click area (to open / close accordian).

Thanks @SyamBabu-M !

@troughc troughc removed their assignment Nov 15, 2024
@SyamBabu-M SyamBabu-M assigned troughc and unassigned SyamBabu-M Nov 20, 2024
@troughc
Copy link
Contributor Author

troughc commented Nov 20, 2024

@SyamBabu-M @dev-aravind I looked at the update here

The delete button works well: PASSED
The accordian works well: PASSED

Two questions:
@dev-aravind did you guys implement the behaviour we discussed the other day? We discussed the idea that an unused concept would go away if it wasn't filled with real text before saving? I don't see this.
@SyamBabu-M did you change the colour of the line (that appears when you drag) to match the blue used in the right navigation (the blue of the selected workspace)? I don't see it.

@troughc troughc added question Further information is requested and removed question Further information is requested labels Nov 20, 2024
@SyamBabu-M
Copy link
Contributor

@SyamBabu-M did you change the colour of the line (that appears when you drag) to match the blue used in the right navigation (the blue of the selected workspace)? I don't see it.

My apologies. I have updated the color to #1B3DE6. Please check again.

did you guys implement the behaviour we discussed the other day? We discussed the idea that an unused concept would go away if it wasn't filled with real text before saving? I don't see this.

Can we discuss this? I am not entirely sure what this is about.

@troughc
Copy link
Contributor Author

troughc commented Nov 21, 2024

Make language title bold
outline concept when dropping another concept inside it (as a sub concept).
After that, good to go!

Future: syam and caitlin will make one or two enhancement tickets to:

  1. add more items to the context menu on the right
  2. make the first field editable when you add a new concept so that the user knows to add the concept name right away (and avoid having concepts named 'concept english' etc.

@troughc
Copy link
Contributor Author

troughc commented Nov 21, 2024

@SyamBabu-M I found another bug that needs to be fixed. when you create a new concept and only enter the name in the first field, the other language fields do not use the language literal from the first field (as in 'this is a test en' in the french field)
This is true whether the other fields is empty or not empty. Do we need to discuss this?

Image

Image

SyamBabu-M pushed a commit that referenced this issue Nov 22, 2024
added logic to filter empty string concept before saving
modularized code for draggable draggableTable closes #1302
@SyamBabu-M
Copy link
Contributor

SyamBabu-M commented Nov 22, 2024

@troughc I have made the changes. Please test this.

@SyamBabu-M I found another bug that needs to be fixed. when you create a new concept and only enter the name in the first field, the other language fields do not use the language literal from the first field (as in 'this is a test en' in the french field) This is true whether the other fields is empty or not empty. Do we need to discuss this?

Image

Image

If any of the concepts are already showing this behavior, just save it again and it will be fixed.

@SyamBabu-M SyamBabu-M assigned troughc and unassigned SyamBabu-M Nov 22, 2024
@troughc
Copy link
Contributor Author

troughc commented Nov 25, 2024

Tested that a fallback language is used if a field is empty: PASSED
Title is bold: PASSED
outline concept when dropping another concept inside it (as a sub concept): PASSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request To be deployed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants