Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to use AWS SDK v2 #36

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix: update to use AWS SDK v2 #36

merged 1 commit into from
Aug 21, 2024

Conversation

jamestelfer
Copy link
Member

@jamestelfer jamestelfer commented Aug 20, 2024

The v1 SDK has been EOL for some time now. Updating to the latest version improves its interoperability with AWS environments (via credential chain updates) and keeps our dependency maintenance risk manageable.

Things to note:

  • the context is now plumbed through to the AWS calls. v2 needs the context, and this gives us a base for further improvement if needed.
  • the fake data in the tests now emulates the paging protocol so that the tests continue to work as expected
  • main has a run() function to centralise the error handling

The rest of the changes are fairly vanilla, similar to any v1 -> v2 upgrade.

@jamestelfer jamestelfer changed the title fix: use AWS SDK v2 fix: update to use AWS SDK v2 Aug 20, 2024
ctgardner
ctgardner previously approved these changes Aug 21, 2024
The v1 SDK has been EOL for some time now.
@jamestelfer jamestelfer merged commit 92a2340 into master Aug 21, 2024
5 checks passed
@jamestelfer jamestelfer deleted the aws-sdk-v2 branch August 21, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants