Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visual stacking issues from container query on FilterBar #5237

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dougmacknz
Copy link
Contributor

@dougmacknz dougmacknz commented Nov 6, 2024

To do:

  • Restore container queries that were switched to media queries in Switch container queries to media queries to avoid stacking context issues #5238
  • Fix annoying jump issue when selecting an option from FilterMultiSelect (and browser doesn't have much height)
  • Fix remaining broken tests
  • Add visual regression tests for these components to check they overlay text with opacity:
    • FilterSelect
    • FilterMultiSelect
    • FilterDatePicker
    • FilterDateRangePicker
    • Menu
    • Tooltip

Copy link

changeset-bot bot commented Nov 6, 2024

🦋 Changeset detected

Latest commit: a4e94ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougmacknz dougmacknz force-pushed the KZN-2808/filter-popover-fun-times branch 2 times, most recently from a349cfb to 930ad60 Compare November 7, 2024 00:29
@dougmacknz dougmacknz force-pushed the KZN-2808/filter-popover-fun-times branch from 930ad60 to a4e94ca Compare November 7, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant