This repository has been archived by the owner on Jan 2, 2024. It is now read-only.
Upgrade to production Nuxt release (1.4.0) #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use .nvmrc to indicate desired version for now. The `engines` object is pretty much useless to anything outside of Heroku since it doesn't enforce a strict requirement. Investigated using the node package [1] to install a specific version of the node binary as a requirement, but there's controversy over bloat factor [2, 3] and it is not yet fully compatible with yarn [4]. [1] https://www.npmjs.com/package/node [2] https://twitter.com/housecor/status/962347301456015360 [3] https://twitter.com/maybekatz/status/958157474397171712 [4] aredridel/node-bin-gen#44
Node 9.8.0 was not happy with previous version lock (4.5.3).
Previously running pre-production release. Includes following adjustments: * Tweak Nuxt config for eslint (passing context) * Swap in `eslint-plugin-vue` for `eslint-plugin-html` & use it along with standard for base rules * Fix alias for components to align with Nuxt 1.x [1] * Export state as function for Vuex store, since using modules mode [2] [1] https://nuxtjs.org/guide/directory-structure#aliases [2] https://nuxtjs.org/guide/vuex-store#modules-mode
As indicated in initial implementation of fetching data back in 42d0f7e. Nuxt modules have come a long way in the past year. Basically follow the documentation [1] to swap out the helper for the module. The module makes axios widely available across the app: * plugins * vuex store * pages * middleware * other modules But notice this does not include external utility files, which is a necessity here for `utils/libcal.js`. The workaround was to pass `this.$axios` from the store to the util as a param. Not sure this will be the longterm solution since there are ongoing discussions in the module repo on potential options on better sharing the configured axios instance with external files. [1] https://axios.nuxtjs.org
And satisfy unmet peer dependencies.
|
All good! |
manolobevia
approved these changes
Mar 21, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Node and all packages while we're at it.