This repository has been archived by the owner on Jan 2, 2024. It is now read-only.
New sign for building hours & occupancy #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need a third child to keep the grid happy. Will be refactored soon when the header is promoted to a component.
* Use viewport width for responsive font-size instead of viewport height * Use flexbox (column) for hours status when it has the main stage
Trying this alternative approach since the LiveOccupancy component wasn't reacting to current Vuex state for occupancy when switching from closed to open. Still not 100% convinced this is a home run (I noticed a flicker of Max Capacity rendering after switching to open) but will test in the wild for a couple days. Great reference for new-ish fetch in Nuxt [1] that helped point me in this alternative direction (see note about mutating local data). [1]: https://nuxtjs.org/blog/understanding-how-fetch-works-in-nuxt-2-12#new-fetch
|
@sew268 @eeh53 You can view the Mann sign on this temp instance: |
sew268
reviewed
Sep 29, 2020
|
Thanks @sew268 😃 Yes this is for the first of the two signs we discussed last week. The plan for the second sign is to promote upcoming events. I don't have anything in my notes re: hours at other locations but please see #182 and feel free to edit/comment with any additional data you want included there. |
|
Deployed to production 🚀 |
cappadona
added a commit
that referenced
this pull request
Sep 20, 2021
For spaces, when categories are involved, we need to be able to use either the main hours from the parent library, or override using the category's hours. Accidentally introduced bug when implementing building occupancy signs in #186. As a result, all hours were returned and first in the list (Africana) was being used for all spaces signs.
cappadona
added a commit
that referenced
this pull request
Sep 21, 2021
For spaces, when categories are involved, we need to be able to use either the main hours from the parent library, or override using the category's hours. Accidentally introduced bug when implementing building occupancy signs in #186. As a result, all hours were returned and first in the list (Africana) was being used for all spaces signs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When open, live occupancy data is displayed.
Initial implementation for following libraries:
Route is
/{{libraryName}}/building