Skip to content
This repository has been archived by the owner on May 20, 2019. It is now read-only.

Change supported Android version down to 4.0, use support fragments #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JackMc
Copy link
Contributor

@JackMc JackMc commented Nov 27, 2017

What are you trying to accomplish with this PR?

Support Android 4.0.

How is this accomplished?

Changing around a couple classes to use the support library versions instead of the regular versions. Also added a fix for an issue where the Context would be null when displaying failed requests.

Checklist

  • I have tested the changes in development
    • Tested on Android 4.0 Jelly Bean and Android 8.0 Oreo
  • I have received review from at least one other team member

@JackMc JackMc requested a review from EstiT November 27, 2017 04:43
Copy link
Contributor

@EstiT EstiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.0 is deprecated. The lowest I could test with is 4.1 Jelly Bean. We'll have to fix this layout first
screen shot 2017-11-27 at 10 35 26 pm

Why does the Main activity have to use the support fragment manager and the schedule fragment can use the fragment manager?

Copy link
Contributor

@EstiT EstiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it. Its alright now. I dont know why the bottom text isnt centred..
screen shot 2017-11-27 at 10 55 50 pm

@JackMc
Copy link
Contributor Author

JackMc commented Nov 28, 2017

I don't think it needs to be perfect, just good enough that it runs on old phones.

@JackMc
Copy link
Contributor Author

JackMc commented Nov 28, 2017

People with old phones will probably blame it on their phones anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants