Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc-7.10 and earlier build with minimal changes, but are not supported #6

Closed
kvanbere opened this issue Feb 19, 2018 · 2 comments
Closed

Comments

@kvanbere
Copy link
Member

kvanbere commented Feb 19, 2018

Can be seen here:
rahulmutt@cf16054

@rahulmutt feel free to add a gate on the options needed for this to build and submit your fork as a pull request.

@kvanbere
Copy link
Member Author

kvanbere commented Mar 6, 2018

see also tsani/servant-github-webhook#11 .

@rahulmutt
Copy link

@donkeybonks Spent some time looking at the blame for the new warning flags and I found this:
ghc/ghc@2206fa8

So essentially, -Wincomplete-uni-patterns -Wincomplete-record-updates can be replaced with -fwarn-incomplete-uni-patterns -fwarn-incomplete-record-updates to make it work for older GHC versions too. According to the commit comment:

The old -fwarn...-based warning flags will remain functional for the forseeable future.

So I think doing s/-W/-fwarn-/ is a safe option that keeps everyone happy. I don't think you should go with my forked changes since I did those in a rush and didn't check to see if there were any alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants