Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Java and PHP code generation using Docker on Windows #147

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

jkronegg
Copy link
Contributor

@jkronegg jkronegg commented Apr 4, 2023

🤔 What's changed?

I corrected the Java and PHP code generation when running using Docker on Windows.

⚡️ What's your motivation?

Fixes #146

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

It seems to be related to new lines differences between Unix and Windows.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje mpkorstanje merged commit 461b71b into main Apr 4, 2023
@mpkorstanje mpkorstanje deleted the docker-window branch April 4, 2023 13:22
@mpkorstanje
Copy link
Contributor

LGTM. Didn't test on a *Nix system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when generating code using Docker on Windows
2 participants