Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Go module name to match repo #101

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Change Go module name to match repo #101

merged 1 commit into from
Nov 14, 2022

Conversation

vearutop
Copy link
Member

🤔 What's changed?

This PR changes Go module name to match source repo.

⚡️ What's your motivation?

go mod tidy in a project with github.com/cucumber/messages/go/v19 import fails with

        github.com/cucumber/messages/go/v19: github.com/cucumber/messages/go/[email protected]: parsing go.mod:
        module declares its path as: github.com/cucumber/common/messages/go/v19
                but was required as: github.com/cucumber/messages/go/v19

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@mpkorstanje
Copy link
Contributor

Looks good. Two semi related questions:

  1. What kind of change is this w.r.t Semver? It doesn't seem to break anything. So I'm guessing it's a fix. Is that correct?
  2. We currently publish a subtree of the go directory to https://github.com/cucumber/messages-go, is this still nessesary?

@vearutop
Copy link
Member Author

vearutop commented Nov 13, 2022

What kind of change is this w.r.t Semver? It doesn't seem to break anything. So I'm guessing it's a fix. Is that correct?

Yes, I suppose the code in this repo isn't currently accessible as a Go module (without custom replaces), so this PR is a fix (patch release).

We currently publish a subtree of the go directory to https://github.com/cucumber/messages-go, is this still nessesary?

I'm not sure, I think github.com/cucumber/messages-go was planned for deprecation (and maybe archiving), originally with the idea of replacing it with monorepo, now with this repo. So probably any automations/maintenance for messages-go could be disabled.

@mpkorstanje mpkorstanje self-assigned this Nov 13, 2022
@mpkorstanje mpkorstanje merged commit 4a71b4a into main Nov 14, 2022
@mpkorstanje mpkorstanje deleted the go-module-name branch November 14, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants