Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest-bdd parse step definition matcher #206

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

kieran-ryan
Copy link
Member

🤔 What's changed?

  • Support the parse step definition matcher of pytest-bdd - which is also used by behave; both Python frameworks

⚡️ What's your motivation?

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@kieran-ryan kieran-ryan added the ⚡ enhancement Request for new functionality label Apr 23, 2024
@kieran-ryan kieran-ryan self-assigned this Apr 23, 2024
@neskk
Copy link

neskk commented Sep 21, 2024

Hello @kieran-ryan,

Found some time to help test this PR.

  • I've added some pytest-bdd parser step definitions to the StepDefinitions.py test file, but I have the ExpressionBuilder tests failing.
  79 passing (1s)
  22 failing

  1) ExpressionBuilder
       with NodeParserAdapter
         builds parameter types and expressions from tsx source:

      AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ []
- [
-   'a {uuid}',
-   'a {date}',
-   'a {planet}',
-   /^a regexp$/,
-   "the bee's knees"
- ]
  • Since my node/vs-code development experience is very limited, I don't know what's the best procedure to test this or contribute with unit-tests. I would appreciate some help. Will the support for this kind of pytest-bdd syntax be hard to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ enhancement Request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pytest-BDD parse matcher step definitions
2 participants