Bugfix/regex regression #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression on checking for the correct symbols in a regex.
Regression on checking for the correct symbols in a regex.
|
@aslakhellesoy This fixes the regression reported in cucumber/vscode#125 |
|
Great. Please add a test that would have failed before this change, and passes with it. |
|
@aslakhellesoy apologies for the delay i have added a |
There was a problem hiding this comment.
I'm merging this. I think a more robust implementation would use the same technique as in https://github.com/cucumber/language-service/blob/main/src/language/tsxLanguage.ts, where we look at the node type to decide how to extract the value, rather than looking at the node text.
But this can be done as a separate refactoring.
| @@ -8,7 +8,7 @@ export const pythonLanguage: Language = { | |||
| case 'string': { | |||
| return stringLiteral(node) | |||
| } | |||
| case 'concatednated_string': { | |||
| case 'concatenated_string': { | |||
There was a problem hiding this comment.
I fixed this typo and nothing broke, so I assume this path isn't tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
⚡️ What's your motivation?
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.